Potential bug with decimal separator

Anything about GOverlay and the devices supported

Potential bug with decimal separator

Postby enderep12 » Thu Apr 12, 2018 4:20 pm

Hello all,

I just received my brand new 3,5" LCDSysinfo for GOverlay 2.0 and finished setting it up.

During the setup, I found an interesting bug:
Using OHWM-DLL Sensors, all data is displayed like this:
- for CPU: 10,14%
- RAM utilisation: 15,25%
- etc.

If I have a percentage indicator like I would use for CPU, it makes sense to limit this to only show 2 max digits (possible via "Max Digits" slider). However if I set this slider to 2, the percentage jumps to 99% and will stay there forever because the program interprets "10,14%" as 1014 (or maybe it just doesnt recognize the , as a separator because it expects a "." instead, which is common in a lot of countries but not in my locale (de_DE).)

On the newest Beta this can be partially fixed by visiting Sensors -> OpenHM and setting the "Comma value setting" to 0 (this does however NOT work in the stable 1.6.4 build). The problem is, that this disbables all values with comma for other sensors where it makes sense to display values after the comma.

Is there a possibility to enable "," as a decimal separator as well somewhere?

Did a quick video to show the problem:
https://www.youtube.com/watch?v=xwGJXTE0Z7M -> switching comma value under "Sensors -> OpenHM" from 0 to 2 and back
https://www.youtube.com/watch?v=boKMs3XHKmc -> (sorry for the horizontal video, it was easier to have both the program and the display in frame this way :D) Keeping comma value under "Sensors -> OpenHM" at 2 and switching the "Max Digits" slider from 0 to 2 to different other numbers (if you set it big enough it will recognise the "10,14%" as 1014 again and will show it, but with the comma)

Thanks and best regards!

enderep12
 
Posts: 16
Joined: Thu Dec 31, 2015 3:23 pm

Re: Potential bug with decimal separator

Postby TheLaGmAn » Mon Apr 16, 2018 2:06 pm

thanks for the report.

by default goverlay should auto detect if you use commas or dots and work with that.
can you restart goverlay and look at this line in the logs

"Culture Type is:" and tell me what it says?
User avatar
TheLaGmAn
Site Admin
 
Posts: 967
Joined: Wed Feb 26, 2014 8:32 pm

Re: Potential bug with decimal separator

Postby enderep12 » Mon Apr 16, 2018 2:24 pm

Hi, the entry regarding culture type in the log is:
Code: Select all
Culture Type is: 2

enderep12
 
Posts: 16
Joined: Thu Dec 31, 2015 3:23 pm

Re: Potential bug with decimal separator

Postby TheLaGmAn » Mon Apr 16, 2018 2:38 pm

okay, try the beta

1.6.4.7_exf
User avatar
TheLaGmAn
Site Admin
 
Posts: 967
Joined: Wed Feb 26, 2014 8:32 pm

Re: Potential bug with decimal separator

Postby enderep12 » Mon Apr 16, 2018 2:48 pm

The new beta is fixing the problem!

I can now have the comma-values enabled in "Sensors" settings and the "Max digits" setting is correctly showing the values!

FWIW: Culture type is still detected as "2".

Thanks!

enderep12
 
Posts: 16
Joined: Thu Dec 31, 2015 3:23 pm

Re: Potential bug with decimal separator

Postby TheLaGmAn » Mon Apr 16, 2018 3:06 pm

Great.

Yes, culture was correct but the module for the cutdigits wasnt using it properly.

Thanks for the report!
User avatar
TheLaGmAn
Site Admin
 
Posts: 967
Joined: Wed Feb 26, 2014 8:32 pm


Return to About GOverlay



Who is online

Users browsing this forum: No registered users and 6 guests

cron